feat(plugins/pins): migrate plugin #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
added
enhancement
…te-plugin-pins # Conflicts: # src/core/types/plugin.ts
…n the boundary of a layer
…low multiple sources
dopenguin
requested review from
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
added a commit
that referenced
this pull request
Oct 21, 2025
# Conflicts: # examples/snowbox/index.js # src/core/types/plugin.ts
…3/migrate-plugin-pins
…3/migrate-plugin-pins
oeninghe-dataport
requested changes
Dec 3, 2025
src/plugins/pins/store.ts
Outdated
Comment on lines
51
to
52
| const latLon = computed(() => | ||
| toLonLat(coordinate.value, coreStore.configuration.epsg) |
Collaborator
There was a problem hiding this comment.
I'm a little bit confused here: Is it lonLat or latLon?
If it is lonLat, why not name it like that?
Member
Author
There was a problem hiding this comment.
Good catch! Fixed this so it reflects the previous functionality 8afe81f
# Conflicts: # examples/snowbox/index.js # src/core/types/main.ts # src/core/types/plugin.ts
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Pins plugin to
@polar/polar.Instructions for local reproduction and review
npm run snowboxRelevant tickets, issues, et cetera
Closes #352
If #366 is merged before this PR, then the
PinsOptionsshould be extended byLayerBoundPluginOptions. Otherwise, this change has to be added to #366.Blocked by #404